Add mobile: command for performing editor actions #428
Conversation
There was a problem hiding this comment.
After https://github.com/appium/appium-adb/pull/354/files/47dcc042040279617083385bcee33060091273ad#diff-83add4eba9c23315341d94aec97ce76b and adding this PR's comment, normal action worked 👍
I'll check further, but this way works 👍
[HTTP] --> POST /wd/hub/session/1bef54aa-ea68-46bb-b0da-8b64826d2688/execute/sync
[HTTP] {"script":"mobile: performEditorAction","args":[{"action":"normal"}]}
[debug] [W3C] Calling AppiumDriver.execute() with args: ["mobile: performEditorAction",[{"action":"normal"}],"1bef54aa-ea68-46bb-b0da-8b64826d2688"]
[debug] [ADB] Performing editor action: normal
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s emulator-5554 shell settings get secure default_input_method'
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s emulator-5554 shell ime enable io.appium.settings/.AppiumIME'
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s emulator-5554 shell ime set io.appium.settings/.AppiumIME'
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s emulator-5554 shell input text /normal/'
[debug] [ADB] Running '/Users/kazuaki/Library/Android/sdk/platform-tools/adb -P 5037 -s emulator-5554 shell ime set io.appium.android.ime/.UnicodeIME'
[debug] [W3C] Responding to client with driver.execute() result: null
[HTTP] <-- POST /wd/hub/session/1bef54aa-ea68-46bb-b0da-8b64826d2688/execute/sync 200 1404 ms - 14
[HTTP]
| startLogsBroadcast: 'mobileStartLogsBroadcast', | ||
| stopLogsBroadcast: 'mobileStopLogsBroadcast', | ||
|
|
||
| performEditorAction: 'mobilePerformEditorAction', |
There was a problem hiding this comment.
Should we add https://github.com/appium/appium-uiautomator2-driver/blob/7af9866353a06f8a7f22675912082fe979811254/lib/commands/general.js#L81 as well?
Since no command error raised without performEditorAction: 'mobilePerformEditorAction', in appium-uiautomator2-driver
There was a problem hiding this comment.
yep, will add it later
There was a problem hiding this comment.
I want the other components to be published first
|
Make sure to update: https://github.com/appium/appium/edit/master/commands-yml/commands/mobile-command.yml as well |
the PR depends on appium/appium-adb#354