chore: Disable automatic screen recording by default #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
## [5.3.3](v5.3.2...v5.3.3) (2023-06-08) ### Miscellaneous Chores * Disable automatic screen recording by default ([#726](#726)) ([a070223](a070223))
KazuCocoa
reviewed
Jun 9, 2023
| @@ -94,6 +94,16 @@ + (void)enableScreenshots | |||
| [[NSUserDefaults standardUserDefaults] setBool:NO forKey:@"DisableScreenshots"]; | |||
| } | |||
|
|
|||
| + (void)disableScreenRecordings | |||
| { | |||
| [[NSUserDefaults standardUserDefaults] setBool:YES forKey:@"DisableDiagnosticScreenRecordings"]; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Xcode 15/iOS 17 Apple has replaced diagnostic screenshots with video recording by default. Obviously this strategy does not really work our scenario, since WDA itself is literally single long test, which would result in a big video recording exceeding the free storage space. that is why it makes sense to disable this feature by default and (hopefully) being able to record videos on-demand while executing the test.