Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add openUrl handler available since Xcode 14.3 #661

Merged
merged 3 commits into from
Feb 19, 2023

Conversation

mykola-mokhnach
Copy link

buildError:error];;
}

- (BOOL)fb_openUrl:(NSString *)url withApplication:(NSString *)bundleId error:(NSError **)error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KazuCocoa
Copy link
Member

I'll test with a real device if I can prepare later. (I need to upgrade my machine)

@KazuCocoa
Copy link
Member

KazuCocoa commented Feb 19, 2023

Confirmed this command worked well on a real device as well. An app scheme also succeeded in launching the app. Eventually...

I also confirmed the open url requires iOS 16.4 as well. Xcode 14.3 x iOS 16.3 got an error by com.apple.dt.xctest.ui-testing.error. So this actually can work with newer Xcode and iOS combinations...

@mykola-mokhnach mykola-mokhnach merged commit bee564e into master Feb 19, 2023
@mykola-mokhnach mykola-mokhnach deleted the open_url branch February 19, 2023 08:04
github-actions bot pushed a commit that referenced this pull request Feb 19, 2023
## [4.11.0](v4.10.24...v4.11.0) (2023-02-19)

### Features

* Add openUrl handler available since Xcode 14.3 ([#661](#661)) ([bee564e](bee564e))
@github-actions
Copy link

🎉 This PR is included in version 4.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants