fix: iOS 13.1 touch coordinates calculation in landscape mode #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Sep 18, 2019
|
oh, how many Xcode releases they needed at Apple to address it... |
|
The change appears to be on the device side actually, iOS 13.0 still behaves in the same manner as before. |
KazuCocoa
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears as if in iOS 13.1 the
frame.sizeproperty ofXCUIApplicationis now returned in accordance to the orientation of the UI, as opposed to previously where it was always returned in a portrait orientation, causingFBInvertPointForApplicationto return incorrect touch coordinates when the UI is in landscape (either states).The logic of the function remains the same, however now the needed dimension is used when calculating the new point:
UIInterfaceOrientationLandscapeLeft.UIInterfaceOrientationLandscapeRight.