fix: Revert "fix: Assert app is installed before launching or activat…

…ing it (#704)" (#705)

This reverts commit 94e5c51.

WebDriverAgentLib/FBApplication.h

@@ -44,16 +44,6 @@ NS_ASSUME_NONNULL_BEGIN
  */
 + (BOOL)fb_switchToSystemApplicationWithError:(NSError **)error;
 
-/**
- Returns the bundle indentifier of the system app (ususally Springboard)
- */
-+ (NSString *)fb_systemApplicationBundleID;
-
-/**
- Checks if the app is installed on the device under test.
- */
-- (BOOL)fb_isInstalled;
-
 @end
 
 NS_ASSUME_NONNULL_END

WebDriverAgentLib/FBApplication.m

@@ -9,15 +9,13 @@
 
 #import "FBApplication.h"
 
-#import "FBExceptions.h"
 #import "FBXCAccessibilityElement.h"
 #import "FBLogger.h"
 #import "FBRunLoopSpinner.h"
 #import "FBMacros.h"
 #import "FBActiveAppDetectionPoint.h"
 #import "FBXCodeCompatibility.h"
 #import "FBXCTestDaemonsProxy.h"
-#import "LSApplicationWorkspace.h"
 #import "XCUIApplication.h"
 #import "XCUIApplication+FBHelpers.h"
 #import "XCUIApplicationImpl.h"
@@ -135,16 +133,6 @@ + (instancetype)fb_systemApplication
    [[FBXCAXClientProxy.sharedClient systemApplication] processIdentifier]];
 }
 
-+ (NSString *)fb_systemApplicationBundleID
-{
-  static dispatch_once_t onceToken;
-  static NSString *systemAppBundleID;
-  dispatch_once(&onceToken, ^{
-    systemAppBundleID = [[self.class fb_systemApplication] bundleID];
-  });
-  return systemAppBundleID;
-}
-
 + (instancetype)applicationWithPID:(pid_t)processID
 {
   if ([NSProcessInfo processInfo].processIdentifier == processID) {
@@ -153,33 +141,14 @@ + (instancetype)applicationWithPID:(pid_t)processID
   return (FBApplication *)[FBXCAXClientProxy.sharedClient monitoredApplicationWithProcessIdentifier:processID];
 }
 
-/**
- https://github.com/appium/WebDriverAgent/issues/702
- */
-- (void)fb_assertInstalledByAction:(NSString *)action
-{
-  if (![self.bundleID isEqualToString:[self.class fb_systemApplicationBundleID]] && !self.fb_isInstalled) {
-    NSString *message = [NSString stringWithFormat:@"The application '%@' cannot be %@ because it is not installed on the device under test",
-                         self.bundleID, action];
-    [[NSException exceptionWithName:FBApplicationMissingException reason:message userInfo:nil] raise];
-  }
-}
-
 - (void)launch
 {
-  [self fb_assertInstalledByAction:@"launched"];
   [super launch];
   if (![self fb_waitForAppElement:APP_STATE_CHANGE_TIMEOUT]) {
     [FBLogger logFmt:@"The application '%@' is not running in foreground after %.2f seconds", self.bundleID, APP_STATE_CHANGE_TIMEOUT];
   }
 }
 
-- (void)activate
-{
-  [self fb_assertInstalledByAction:@"activated"];
-  [super activate];
-}
-
 - (void)terminate
 {
   [super terminate];
@@ -212,9 +181,4 @@ + (BOOL)fb_switchToSystemApplicationWithError:(NSError **)error
           error:error];
 }
 
-- (BOOL)fb_isInstalled
-{
-  return [[LSApplicationWorkspace defaultWorkspace] applicationIsInstalled:self.bundleID];
-}
-
 @end

WebDriverAgentLib/Routing/FBExceptionHandler.m

@@ -24,8 +24,7 @@ - (void)handleException:(NSException *)exception forResponse:(RouteResponse *)re
     commandStatus = [FBCommandStatus noSuchDriverErrorWithMessage:exception.reason
                                                         traceback:traceback];
   } else if ([exception.name isEqualToString:FBInvalidArgumentException]
-             || [exception.name isEqualToString:FBElementAttributeUnknownException]
-             || [exception.name isEqualToString:FBApplicationMissingException]) {
+             || [exception.name isEqualToString:FBElementAttributeUnknownException]) {
     commandStatus = [FBCommandStatus invalidArgumentErrorWithMessage:exception.reason
                                                            traceback:traceback];
   } else if ([exception.name isEqualToString:FBApplicationCrashedException]

WebDriverAgentLib/Routing/FBExceptions.h

@@ -49,7 +49,4 @@ extern NSString *const FBClassChainQueryParseException;
 /*! Exception used to notify about application crash */
 extern NSString *const FBApplicationCrashedException;
 
-/*! Exception used to notify about the application is not installed  */
-extern NSString *const FBApplicationMissingException;
-
 NS_ASSUME_NONNULL_END

WebDriverAgentLib/Routing/FBExceptions.m

@@ -20,4 +20,3 @@
 NSString *const FBXPathQueryEvaluationException = @"FBXPathQueryEvaluationException";
 NSString *const FBClassChainQueryParseException = @"FBClassChainQueryParseException";
 NSString *const FBApplicationCrashedException = @"FBApplicationCrashedException";
-NSString *const FBApplicationMissingException = @"FBApplicationMissingException";

WebDriverAgentTests/IntegrationTests/FBSessionIntegrationTests.m

@@ -11,7 +11,6 @@
 
 #import "FBIntegrationTestCase.h"
 #import "FBApplication.h"
-#import "FBExceptions.h"
 #import "FBMacros.h"
 #import "FBSession.h"
 #import "FBXCodeCompatibility.h"
@@ -101,34 +100,6 @@ - (void)testMainAppCanBeRestartedInScopeOfTheCurrentSession
   FBAssertWaitTillBecomesTrue([self.session.activeApplication.bundleID isEqualToString:testedApp.bundleID]);
 }
 
-- (void)testAppWithInvalidBundleIDCannotBeStarted
-{
-  FBApplication *testedApp = [[FBApplication alloc] initWithBundleIdentifier:@"yolo"];
-  @try {
-    [testedApp launch];
-    XCTFail(@"An exception is expected to be thrown");
-  } @catch (NSException *exception) {
-    XCTAssertEqualObjects(FBApplicationMissingException, exception.name);
-  }
-}
-
-- (void)testAppWithInvalidBundleIDCannotBeActivated
-{
-  FBApplication *testedApp = [[FBApplication alloc] initWithBundleIdentifier:@"yolo"];
-  @try {
-    [testedApp activate];
-    XCTFail(@"An exception is expected to be thrown");
-  } @catch (NSException *exception) {
-    XCTAssertEqualObjects(FBApplicationMissingException, exception.name);
-  }
-}
-
-- (void)testAppWithInvalidBundleIDCannotBeTerminated
-{
-  FBApplication *testedApp = [[FBApplication alloc] initWithBundleIdentifier:@"yolo"];
-  [testedApp terminate];
-}
-
 - (void)testLaunchUnattachedApp
 {
   [FBUnattachedAppLauncher launchAppWithBundleId:SETTINGS_BUNDLE_ID];