Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlined SVG files got broken (empty, blank) #3575

Closed
maxceem opened this issue Jan 29, 2020 · 4 comments
Closed

Inlined SVG files got broken (empty, blank) #3575

maxceem opened this issue Jan 29, 2020 · 4 comments
Assignees
Milestone

Comments

@maxceem
Copy link
Collaborator

maxceem commented Jan 29, 2020

Follow up from #3407 (comment) issue number 2.

If SVG file uses ids for mask and/or for defs such ids may get collied because SVG files are inlined and ids inside SVGs are global for the whole HTML.

For example, we have an issue that the same icon first time is shown good:

image

But the next times it's shown blank (broken):

image

Here are related issues found on the internet:

Workarounds from these issues don't help us, unfortunately. So the only working solution was to edit the code of SVG file manually, so it doesn't use ids and masks.

We may still come across such issues in the future, as so far the solution may be applied only per SVG files that have such an issue. Probably, we can also ask designers to provide SVG files without masks if possible.

@maxceem maxceem changed the title Inlined SVG files got broken, empty Inlined SVG files got broken (empty, blank) Jan 29, 2020
@maxceem maxceem self-assigned this Jan 29, 2020
@maxceem maxceem added this to the 2.5.1 milestone Jan 29, 2020
maxceem added a commit that referenced this issue Jan 29, 2020
2. Tick mark in the 'Join button' is visible only for the first invitation when there are multiple invitations

refs: issue #3407, issue #3575
@maxceem
Copy link
Collaborator Author

maxceem commented Jan 29, 2020

This is actually a part of #3407 (comment).
I've logged this issue separately, so it would be easier to find it if we have similar issues in the future.

@RishiRajSahu
Copy link
Contributor

@maxceem good research ! 👍

@vikasrohit
Copy link

Closing. Please feel free to create new issues for any regression.

@chaitanya71998
Copy link

make your fill using ids unique, in the svg component, so that react will render each svg component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants