This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
Change library used to encode manifest. #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manifest was encoded using official encoding/json which does not canonical encode data. Use library from github.com/docker/go/canonical/json instead.
|
I'm concerned about use of github.com/docker/go. The library is uncommon; it is used (almost?) exclusively by Docker's Notary and appears to be poorly maintained or dormant (the only release in 2015, last commit 2+ years ago)... Perhaps it would be best to avoid this library. |
|
For reference, this PR comes from the discussion at #245. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifest was encoded using official encoding/json which does not canonical encode data.
Use library from github.com/docker/go/canonical/json instead.