Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

Initial implementation for acpush #1

Merged
merged 2 commits into from
Feb 11, 2016
Merged

Initial implementation for acpush #1

merged 2 commits into from
Feb 11, 2016

Conversation

cgonyeo
Copy link
Member

@cgonyeo cgonyeo commented Oct 7, 2015

Currently supports performing meta discovery to find appropriate endpoint, and pushing provided image and signature to the server. Relies on rkt's config files for authentication.

@cgonyeo
Copy link
Member Author

cgonyeo commented Oct 7, 2015

Implements client side of appc/spec#418

@cgonyeo
Copy link
Member Author

cgonyeo commented Oct 28, 2015

Should be ready for another pass

@cgonyeo
Copy link
Member Author

cgonyeo commented Dec 1, 2015

Another pass on this would be great.

@jonboulle
Copy link
Contributor

@steveej review?

@cgonyeo
Copy link
Member Author

cgonyeo commented Dec 10, 2015

$ bundle --version
Bundler version 1.7.6
$ gem --version
2.4.5
$ rake
rake aborted!

Perhaps disable travis on this repo for the time being?

@jonboulle
Copy link
Contributor

changed travis to only build if .travis.yml is supplied

Derek Gonyeo added 2 commits December 15, 2015 11:05
Currently supports performing meta discovery to find appropriate
endpoint, and pushing provided image and signature to the server. Relies
on rkt's config files for authentication.
@cgonyeo
Copy link
Member Author

cgonyeo commented Dec 15, 2015

Removed the binary, reformatted the README to have one sentence per line, and tweaked the build instructions in the REAME. Should be ready for another pass @steveej.

@cgonyeo
Copy link
Member Author

cgonyeo commented Jan 27, 2016

ping?

@steveej
Copy link

steveej commented Feb 6, 2016

LGTM if it works

@philips
Copy link

philips commented Feb 6, 2016

The idea is that this will be a library for use by rkt, right?

@cgonyeo
Copy link
Member Author

cgonyeo commented Feb 6, 2016

Yes, if rkt gains the ability to export an exited container's rootfs. I think it makes more sense to put it in acbuild, if only because that's the tool that modifies images, and pushing unmodified images doesn't sound particularly exciting.

@philips
Copy link

philips commented Feb 6, 2016

I think rkt should have push/pull because it makes it symmetric. I see the
process as build with your build tool, fetch/import into rkt, push from rkt.

On Sat, Feb 6, 2016 at 2:35 PM Derek Gonyeo [email protected]
wrote:

Yes, if rkt gains the ability to export an exited container's rootfs. I
think it makes more sense to put it in acbuild, if only because that's the
tool that modifies images, and pushing unmodified images doesn't sound
particularly exciting.


Reply to this email directly or view it on GitHub
#1 (comment).

jonboulle added a commit that referenced this pull request Feb 11, 2016
Initial implementation for acpush
@jonboulle jonboulle merged commit cd91bd9 into appc:master Feb 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants