Add tests to rds.go #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janboll
force-pushed
the
refactor-rds
branch
from
6180e04 to
0ed9bda
Compare
Split up CollectLoop: * Move corrosponding code sections into individual methods * Make individual methods concurrent to speed up metrics collection * Refactor collectLogMetrics adapt concurrency to match pattern established in route53.go
Remove not used functions
janboll
force-pushed
the
refactor-rds
branch
4 times, most recently
from
5b66423 to
9bb8d2d
Compare
Needed to refactor to be able to mock out AWS results. Reason being is the switch to pagination methods. Created new *All methods in awsclient.go. By adding them to the inteface, it is possible to mock out the result for these paginated methods. Next refactoring was to make the fields in the RDSExporter struct simple variables, that way the tests can create simple RDSExporter objects that support only single tests cases. Otherwise the NewRDSExporter Methods would have required some substantial refactoring.
janboll
force-pushed
the
refactor-rds
branch
from
9bb8d2d to
d96f309
Compare
This is required to restore the metrics count for RDS requests. Since the describe methods where move to the *All Methods, we can't reliable call the number of counts in the rds.go anymore. So move the exporter to the awsclient package.
suzana-nesic
approved these changes
Sep 29, 2022
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to enable testing, split up CollectLoop:
Going commit by commit could make the review simpler.
related ticket: https://issues.redhat.com/browse/APPSRE-6310