Fix nil pointer references #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrWinston
approved these changes
Sep 19, 2022
|
For my knowledge, in which case do we get |
|
That's a very good question. I was fingering from the fact, that the function returns a pointer. Also the code is failing at i.e. line 154, if you check that line the only thing, that can be nil is the output. Not sure, but it might be an issue with the SDK, found for instance: aws/aws-sdk-go#3619 |
|
Tested locally using our stage and prod AWS accounts. |
|
Removed the nil check and just bumped the SDK to check if was only an upstream issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vpc.go sometimes crashes with nil pointer reference. The stacktrace indicates, that it's related to nil values returned for certain AWS calls