-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terminal profile support #37
Conversation
Awaiting |
I feel like this PR tries to do too much things together. Maybe it's better to just focus on the terminal profile here, and have a look at other changes in other PR? |
Sure, can roll back to the terminal profile commit I bet you'll have the first extension using this new feature 😄 |
Done! |
Any ETA on merging this? |
Yeah sorry I have been busy lately. I'll try to have a look this weekend and merge it if everything is fine. |
It's no problem, hope you can get to it when you're ready |
I've noticed this branch is still in my list, any dice? I've been testing it a lot and it works great |
Hey sorry for the delay. I was able to take a look at it today. It does not work for me, I guess you did not push the latest version: some variables have wrong names I think, I'll review it. |
Okay it works now but I found an issue in the new feature: if I try to open a MATLAB terminal from the integrated terminal without having activated the extension before (so without being on a .m file for example), it fails with the following error |
We'd make it activate on |
Co-authored-by: Aurélien Pommel <[email protected]>
It's fine with me like this. I'll merge it. However if at some point there is an activation event such as |
https://code.visualstudio.com/updates/v1_57 mentions |
Closes #33.