This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
add option to pass extra websocket client arguments #561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Two of the most used websocket node implementation both support 3rd or more arguments to the constructor. Referring to ws doc and WebSocket-Node doc
This PR try adding an extra property to
ClientOptions
that can be used to pass extra arguments to the custom ws implementation.