-
Notifications
You must be signed in to change notification settings - Fork 341
Conversation
@nirinchev: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
CI seems to be failing with a test that passes locally - I imagine it's possible that this change triggers an underlying race condition with that test. I'll investigate. |
Can I get some guidance on the direction this PR takes and whether it's something you'd like to merge? I'd be happy to add tests and update the changelog as soon as I get some confirmation that this change is consistent with the direction you'd like to take with this library. |
I think an approach along the lines of apollo-server, would be for the |
@NeoPhi thanks for the feedback - can you review if the current implementation is aligned with what you had in mind? |
This is looking great. We will also want updates for the README and docs. |
I updated the readme and the docs - they don't seem to be too verbose, so wasn't sure into how much detail I should go. |
Thank you very much! |
You're welcome! Do you guys do releases based on fixed time periods or when a certain number of features/bug fixes accumulate? Just wondering what timeframe to give our customers about this making it into an official release 🙂 |
I've been trying to do continuous releases. As such https://github.com/apollographql/subscriptions-transport-ws/releases/tag/v0.9.14 just published. |
This reverts commit 40c3c3c.
Sometimes, the GraphQL schema needs to be dynamically resolved (e.g. when exposing a database interface). This change allows the schema to be provided either as a static value or as a function of the connection context:
There are no tests for it since it's a fairly trivial change and I wasn't sure if it would be accepted, but I can write some smoke tests if required.
TODO: