This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 341
Pass request (upgradeReq) to ConnectionContext #369
Merged
mxstbr
merged 4 commits into
apollographql:master
from
kamilkisiela:feature/request-to-context
Mar 19, 2018
Merged
Pass request (upgradeReq) to ConnectionContext #369
mxstbr
merged 4 commits into
apollographql:master
from
kamilkisiela:feature/request-to-context
Mar 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kamilkisiela
commented
Mar 12, 2018
- Make sure all of the significant new logic is covered by tests
- Rebase your changes on master so that they can be merged easily
- Make sure all tests and linter rules pass
- Update CHANGELOG.md with your change
mxstbr
reviewed
Mar 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a note about this to the docs, and should onDisconnect
also get the connectionContext
as the second arg?
Right now it's weird how onConnect
and onDisconnect
converge in the information passed to them:
onConnect(params, socket, context)
onDisconnect(socket) // 😢
// Let's make that
onDisconnect(socket, context)
@mxstbr Pushed |
mxstbr
approved these changes
Mar 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 💯
@mxstbr can we please get a release with this feature? 😄 thank you! |
I unfortunately don't have npm publish permissions, only GitHub permissions. /cc @jbaxleyiii |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.