Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Pass request (upgradeReq) to ConnectionContext #369

Merged
merged 4 commits into from
Mar 19, 2018

Conversation

kamilkisiela
Copy link
Contributor

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@kamilkisiela kamilkisiela added the feature New addition or enhancement to existing solutions label Mar 12, 2018
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a note about this to the docs, and should onDisconnect also get the connectionContext as the second arg?

Right now it's weird how onConnect and onDisconnect converge in the information passed to them:

onConnect(params, socket, context)
onDisconnect(socket) // 😢
// Let's make that
onDisconnect(socket, context)

@kamilkisiela
Copy link
Contributor Author

@mxstbr Pushed

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 💯

@mxstbr mxstbr merged commit bff322c into apollographql:master Mar 19, 2018
@kamilkisiela kamilkisiela deleted the feature/request-to-context branch March 19, 2018 08:31
@dotansimha
Copy link
Contributor

dotansimha commented Mar 19, 2018

@mxstbr can we please get a release with this feature? 😄 thank you!

@mxstbr
Copy link
Contributor

mxstbr commented Mar 19, 2018

I unfortunately don't have npm publish permissions, only GitHub permissions. /cc @jbaxleyiii

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New addition or enhancement to existing solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants