Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Client connection events #136

Closed
mistic opened this issue May 18, 2017 · 4 comments
Closed

Client connection events #136

mistic opened this issue May 18, 2017 · 4 comments

Comments

@mistic
Copy link
Contributor

mistic commented May 18, 2017

Guys ( @Urigo @DxCx @helfer @dotansimha @NeoPhi ) this issue is to allow us think about the events we are throwing during the connection handshake between the client and the server. At the moment we are only emitting a single event called connect or reconnect when the onopen callback runs. In my opinion we should do this:

  • emit a connecting or reconnecting event (according it is a connect or reconnect situation) when the onopen callback runs
  • emit a connected or reconnected event when we receive the GQL_CONNECTION_ACK.

What do u think?

@dotansimha
Copy link
Contributor

dotansimha commented May 19, 2017

Sounds good @mistic .
I think it will also help to implement an good client side indication for the socket status (connecting/connected/disconnection/reconnecting)

@Urigo
Copy link
Contributor

Urigo commented May 19, 2017

@mistic would you want to open a PR?
We might even get this in for the next release

@mistic
Copy link
Contributor Author

mistic commented May 19, 2017

@Urigo @dotansimha I'll open a PR for this. I'm just finishing something even more important so I can open another PR before this one.

@mistic
Copy link
Contributor Author

mistic commented May 19, 2017

@Urigo @dotansimha It's done. Please check #139. I think we can add the label waiting for release

baconz pushed a commit to PhiloInc/subscriptions-transport-ws that referenced this issue Apr 24, 2018
* improve log function

* fix test cases

* update changelog

* add PR to changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants