This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 341
Client connection events #136
Labels
Comments
Sounds good @mistic . |
@mistic would you want to open a PR? |
@Urigo @dotansimha I'll open a PR for this. I'm just finishing something even more important so I can open another PR before this one. |
@Urigo @dotansimha It's done. Please check #139. I think we can add the label |
4 tasks
baconz
pushed a commit
to PhiloInc/subscriptions-transport-ws
that referenced
this issue
Apr 24, 2018
* improve log function * fix test cases * update changelog * add PR to changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Guys ( @Urigo @DxCx @helfer @dotansimha @NeoPhi ) this issue is to allow us think about the events we are throwing during the connection handshake between the client and the server. At the moment we are only emitting a single event called
connect
orreconnect
when theonopen
callback runs. In my opinion we should do this:connecting
orreconnecting
event (according it is a connect or reconnect situation) when theonopen
callback runsconnected
orreconnected
event when we receive theGQL_CONNECTION_ACK
.What do u think?
The text was updated successfully, but these errors were encountered: