Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: install volta via chocolatey instead of flaky MSI installer #1718

Merged
merged 31 commits into from
Aug 21, 2023
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
17ee6a6
chore: updates windows server to 2022
EverlastingBugstopper Aug 18, 2023
af67a08
Merge branch 'main' into avery/attempt-windows-box-update
EverlastingBugstopper Aug 18, 2023
35dd173
chore: attempt to force msiexec to complete before continuing
EverlastingBugstopper Aug 18, 2023
886a851
chore: attempt to use Start-Process for msiexec
EverlastingBugstopper Aug 18, 2023
426f02e
chore: fix quote escaping
EverlastingBugstopper Aug 18, 2023
187e003
chore: print logs
EverlastingBugstopper Aug 18, 2023
fe8d819
chore: try to not exit code
EverlastingBugstopper Aug 18, 2023
b9496a0
chore: another logging attempt
EverlastingBugstopper Aug 18, 2023
489a4bd
chore: adds /L
EverlastingBugstopper Aug 18, 2023
dd34937
chore: switch to zip + path rather than msi
EverlastingBugstopper Aug 18, 2023
c9ce7c7
Merge branch 'main' into avery/attempt-windows-box-update
EverlastingBugstopper Aug 18, 2023
b4a69e9
chore: attempt to keep path around between jobs
EverlastingBugstopper Aug 18, 2023
94cbfc6
chore: move volta to working dir
EverlastingBugstopper Aug 18, 2023
5340219
chore: bumps server back down to 2019
EverlastingBugstopper Aug 18, 2023
a03fd81
chore: move windows volta execution to install step because of path i…
EverlastingBugstopper Aug 18, 2023
adbc6ee
chore: env var it up
EverlastingBugstopper Aug 18, 2023
d6ba933
chore: use bash to run volta in windows
EverlastingBugstopper Aug 18, 2023
828ae3d
chore: proper env var for bash
EverlastingBugstopper Aug 18, 2023
a5bedf6
chore: move to :USERPROFILE\bin
EverlastingBugstopper Aug 21, 2023
7afef84
chore: run volta --version
EverlastingBugstopper Aug 21, 2023
1efdfa2
chore: echo /Users/avery/dev/roverATH
EverlastingBugstopper Aug 21, 2023
836d387
chore: try to add to WindowsApps instead of \bin
EverlastingBugstopper Aug 21, 2023
3af1b48
chore: clean up echo statements
EverlastingBugstopper Aug 21, 2023
5c937aa
Merge branch 'main' into avery/attempt-windows-box-update
EverlastingBugstopper Aug 21, 2023
ceab75a
chore: try to add local\volta to path
EverlastingBugstopper Aug 21, 2023
37ab67a
chore: adds last missing quote
EverlastingBugstopper Aug 21, 2023
942de81
chore: add to path before running
EverlastingBugstopper Aug 21, 2023
cb788b0
chore: debug new path
EverlastingBugstopper Aug 21, 2023
1793add
chore: try to install volta w/chocolatey
EverlastingBugstopper Aug 21, 2023
10bea1e
chore: choco install volta -y
EverlastingBugstopper Aug 21, 2023
2ece081
chore: removes useless or
EverlastingBugstopper Aug 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -371,15 +371,8 @@ commands:
- run:
name: Install volta
command: |
$installer_dir = "$Env:TEMP".Path
$latest_version = ((Invoke-WebRequest -URI https://volta.sh/latest-version).Content -split '\n')[0]
$download_url = "https://github.com/volta-cli/volta/releases/download/v$latest_version/volta-$latest_version-windows-x86_64.msi"
echo "Downloading volta"
$msi_path = "$installer_dir\volta-init.msi"
(New-Object System.Net.WebClient).DownloadFile("$download_url", "$msi_path")
echo "Installing volta"
msiexec.exe /i "$msi_path" /qn
exit $LASTEXITCODE
choco install volta -y

- unless:
condition:
equal: [*arm_ubuntu_executor, << parameters.platform >>]
Expand Down Expand Up @@ -471,7 +464,6 @@ commands:
paths:
- C:\\Users\\circleci\.cargo


- when:
condition:
equal: [package, << parameters.command >>]
Expand Down