docs(telemetry): update instructions for disabling telemetry #1715
Conversation
LongLiveCHIEF
requested review from
a team and
EverlastingBugstopper
as code owners
|
Gotta love CI bugs. @EverlastingBugstopper can you smack the CI runner and see if it recognizes |
|
yeah volta installs have been unfortunately fairly flaky on windows :( - kicked the build hopefully it works |
There was a problem hiding this comment.
Thanks for this change, I think it's an improvement since it makes the behavior match the router.
I want to make sure we keep this contract along with the old one working. Would you mind duplicating the it_can_be_disabled test in src/utils/telemetry.rs on line 187 and test the value 1 in addition to the value true?
|
Sure. I'll be able to get to it later this afternoon. |
LongLiveCHIEF
force-pushed
the
update-telemetry-env-var-setting
branch
from
8acbecc to
9db9187
Compare
LongLiveCHIEF
changed the title
|
I turned on auto-merge for this so it should merge as soon as you update this branch w/latest commits from |
EverlastingBugstopper
added
the
docs 📝
The router requires that this option be a boolean
Head branch was pushed to by a user without write access
LongLiveCHIEF
force-pushed
the
update-telemetry-env-var-setting
branch
from
9db9187 to
9a3a864
Compare
It's passed all checks, and rebased against main, but still not merging for some reason. |
|
Huh, it must have turned off auto-merge after rebasing from main. Regardless - it's merged now, thanks for the contribution! |
lol, it's a self-defeating prophecy! |
The router requires that this option be a boolean
Fixes #1714