Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize Rover #1066

Closed
wants to merge 1 commit into from
Closed

Dockerize Rover #1066

wants to merge 1 commit into from

Conversation

carlocorradini
Copy link

Trying fixing #719

Initial work attempting to dockerize Rover in the manner of Apollo Router.

Missing:

  • rover-fed2 image. Tried without success. Need help!
  • Fix CircleCI config.yml file.
  • GitHub Packages serup for Rover under ghcr.io/apollographql/rover

Having a dockerized Rover image can be super useful in multiple situations: CI, CD, simple tasks, ...

@apollo-cla
Copy link

@carlocorradini: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@netlify
Copy link

netlify bot commented Apr 6, 2022

👷 Deploy request for apollo-cli-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9bfc65a

@EverlastingBugstopper
Copy link
Contributor

Hey @carlocorradini - appreciate the work on this. At this time, we won't be publishing official Docker images for Rover as there isn't a great one size fits all approach, especially since rover supergraph compose cannot run on musl images due to its dependency on deno. You're likely better off extending your own applications image to download and install Rover - we try hard to make sure Rover has minimal requirements as far as other system tools go, and if you need rover supergraph compose, you'll need to do so on an amd64 image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants