Fix: revert tracing dependency bump and pin it. #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts a tracing dependency bump that causes tests to miss spans, possibly related to [the switch from lazy_static to once_cell](tokio-rs/tracing@10da62710227eb445fab7c659d99b81700e6a32co) in tracing-core.
This comment has been minimized.
This comment has been minimized.
SimonSapin
approved these changes
Jul 18, 2022
BrynCooke
approved these changes
Jul 18, 2022
garypen
reviewed
Jul 18, 2022
Geal
approved these changes
Jul 18, 2022
garypen
approved these changes
Jul 18, 2022
Merged
o0Ignition0o
added a commit
that referenced
this pull request
Jul 18, 2022
# [0.12.0] - 2022-08-18 ## ❗ BREAKING ❗ ### Move `experimental.rhai` out of `experimental` [PR #1365](#1365) You will need to update your YAML configuration file to use the correct name for `rhai` plugin. ```diff - plugins: - experimental.rhai: - filename: /path/to/myfile.rhai + rhai: + scripts: /path/to/directory/containing/all/my/rhai/scripts (./scripts by default) + main: <name of main script to execute> (main.rhai by default) ``` You can now modularise your rhai code. Rather than specifying a path to a filename containing your rhai code, the rhai plugin will now attempt to execute the script specified via `main`. If modules are imported, the rhai plugin will search for those modules in the `scripts` directory. for more details about how rhai makes use of modules, look at [the rhai documentation](https://rhai.rs/book/ref/modules/import.html). The simplest migration will be to set `scripts` to the directory containing your `myfile.rhai` and to rename your `myfile.rhai` to `main.rhai`. By [@garypen](https://github.com/garypen) in #1365 ## 🐛 Fixes ### The opentelemetry-otlp crate needs a http-client feature [PR #1392](#1392) The opentelemetry-otlp crate only checks at runtime if a HTTP client was added through cargo features. We now use reqwest for that. By [@Geal](https://github.com/geal) in #1392 ### Expose the custom endpoints from RouterServiceFactory ([PR #1402](#1402)) Plugin HTTP endpoints registration was broken during the Tower refactoring. We now make sure that the list of endpoints is generated from the `RouterServiceFactory` instance. By [@Geal](https://github.com/geal) in #1402 ## 🛠 Maintenance ### Dependency updates [PR #1389](#1389) [PR #1394](#1394) [PR #1395](#1395) Dependency updates were blocked for some time due to incompatibilities: - #1389: the router-bridge crate needed a new version of `deno_core` in its workspace that would not fix the version of `once_cell`. Now that it is done we can update `once_cell` in the router - #1395: `clap` at version 3.2 changed the way values are extracted from matched arguments, which resulted in panics. This is now fixed and we can update `clap` in the router and related crates - #1394: broader dependency updates now that everything is locked - #1410: revert tracing update that caused two telemetry tests to fail (the router binary is not affected) By [@Geal](https://github.com/Geal) in #1389 #1394 #1395 and [@o0Ignition0o](https://github.com/o0Ignition0o) in #1410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts a tracing dependency bump that causes tests to miss spans, possibly related to the switch from lazy_static to once_cell in tracing-core.