Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Listen to unix socket path #154

Closed
hsblhsn opened this issue Nov 17, 2021 · 2 comments · Fixed by #158
Closed

Feature Request: Listen to unix socket path #154

hsblhsn opened this issue Nov 17, 2021 · 2 comments · Fixed by #158
Assignees
Labels

Comments

@hsblhsn
Copy link

hsblhsn commented Nov 17, 2021

First of all thank you for this great project. While using @apollo/gateway, performance is always a concern. Specially when it comes to a cold start. And I believe this project will resolve the issue.

The problem
We have internal tools which uses @apollo/gateway just to integrate all of our subgraphs. Which communicates over unix socket. Because unix socket is twice faster and efficient than regular tcp socket when it comes to inter-process communication. While experimenting with router, we have realized that router does not support unix socket.

Describe alternatives you've considered
Currently we are using apollo-server with @apollo/gateway which uses nodejs http module under the hood. And it has support for unix socket built in. (ex: server.listen('/tmp/gateway')).

@hsblhsn hsblhsn added the triage label Nov 17, 2021
@cecton cecton self-assigned this Nov 17, 2021
@cecton cecton mentioned this issue Nov 18, 2021
@cecton
Copy link
Contributor

cecton commented Nov 18, 2021

@hsblhsn should the subgraphs be contactable by unix sockets too?

@hsblhsn
Copy link
Author

hsblhsn commented Nov 19, 2021

At this moment we are not using unix socket for communicating with subgraphs. But it will be a good feature to support.

@abernix abernix added feature and removed triage labels Feb 4, 2022
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this issue Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants