This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Fix #312 #537
Merged
Fix #312 #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebmer
changed the title
|
@calebmer: This fix solves the issue for me. Thank you! |
|
Thanks, this also solves it in the real app in which I discovered the bug. |
|
Released in 1.0.0-rc.3 🎉 |
|
This solves for me also an instance in which a query was not being triggered if specified the options as an object. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
cc @drager, @steventebrinke
We were mutating the
optionsobject where we weren’t supposed to. So if a user had used an object instead of a function for theiroptionsthen in some cases we would be setting thevariablesproperty incorrectly. I found the bug by callingObject.freezeonoptionsif it was not a function.There error was reproduced in: https://github.com/steventebrinke/react-apollo-error-template/commit/e80ca5ed7a89cbed0b7d39f44d24ffb433f3e111