This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Allow minor releases of lodash #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cherewaty: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
cherewaty
force-pushed
the
lodash-versioning
branch
2 times, most recently
from
9f5225a to
c4f7e0c
Compare
cherewaty
force-pushed
the
lodash-versioning
branch
from
c4f7e0c to
33748a9
Compare
|
#2021 upgraded |
abernix
approved these changes
May 31, 2018
There was a problem hiding this comment.
LGTM.
I don't think that pinning this lodash was really done intentionally (but rather an artifact of previous exact-pinning by Renovate).
If it improves the situation for you by allowing some de-duplication, that seems like good enough reason to get this in.
cherewaty
force-pushed
the
lodash-versioning
branch
from
33748a9 to
d53c384
Compare
|
Thanks @abernix. I rebased to get a green light from Circle, so this should be ready to merge. |
hwillson
approved these changes
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
On a project where I use
react-apolloandlodash, I got a warning fromduplicate-package-checkerthat I have two versions oflodash. It'd be nice to only have one.Approach
Allow minor releases of
lodashabove the specified inpackage.json, so projects consumingreact-apollowill get the latest[email protected].Prior work
#1478 moved
lodashfromdevDependencies(where being locked into a specific patch release was fine) todependencies.