Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

interface MutationOpts lacks some properties #750

Closed
pawsong opened this issue Jun 3, 2017 · 7 comments
Closed

interface MutationOpts lacks some properties #750

pawsong opened this issue Jun 3, 2017 · 7 comments

Comments

@pawsong
Copy link

pawsong commented Jun 3, 2017

Buggy Behavior

I found MutationOpts does not contains refetchQueries, which is documented here and already in apollo-client's MutationOptions. Is there any reason to redefine mutation option typing in react-apollo?

Version

@beagleknight
Copy link

+1 to this. The MutationOpts doesn't contain update as well like the documentation suggests:
http://dev.apollodata.com/react/cache-updates.html#directAccess

@helfer
Copy link
Contributor

helfer commented Jun 20, 2017

This was probably just an oversight. A PR to fix it would be appreciated! 🙂

@beagleknight
Copy link

@helfer @pawsong This is already fixed here: #770

jbaxleyiii pushed a commit that referenced this issue Jul 5, 2017
* TypeScript: missing properties in MutationOpts (fix for #750)

* Flow: missing properties in MutationOpts (fix for #750)
@stale stale bot added the wontfix label Jul 5, 2017
@stale
Copy link

stale bot commented Jul 5, 2017

This issue has been automatically marked as stale becuase it has not had recent activity. It will be closed if not further activity occurs. Thank you for your contributions to React Apollo!

@settings settings bot removed the wontfix label Jul 8, 2017
@stale
Copy link

stale bot commented Jul 29, 2017

This issue has been automatically labled because it has not had recent activity. If you have not received a response from anyone, please mention the repository maintainer (most likely @jbaxleyiii). It will be closed if no further activity occurs. Thank you for your contributions to React Apollo!

@stale
Copy link

stale bot commented Aug 22, 2017

This issue has been automatically labled because it has not had recent activity. If you have not received a response from anyone, please mention the repository maintainer (most likely @jbaxleyiii). It will be closed if no further activity occurs. Thank you for your contributions to React Apollo!

@stale stale bot closed this as completed Sep 5, 2017
@stale
Copy link

stale bot commented Sep 5, 2017

This issue has been automatically closed because it has not had recent activity after being marked as no recent activyt. If you belive this issue is still a problem or should be reopened, please reopen it! Thank you for your contributions to React Apollo!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants