Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Ensure the recycler keys on the client #513

Closed
tmeasday opened this issue Mar 8, 2017 · 5 comments
Closed

Ensure the recycler keys on the client #513

tmeasday opened this issue Mar 8, 2017 · 5 comments
Labels
feature New addition or enhancement to existing solutions

Comments

@tmeasday
Copy link
Contributor

tmeasday commented Mar 8, 2017

See this series of comments: #462 (comment)

The principal issue is in testing, where the same HoC will cache queries even if you render a new tree with a completely different client.

And @calebmer's proposed solution:

A solution would be to, as you suggest, create a WeakMap<ApolloClient, ObservableQueryRecycler> and then we use the recycler for whichever client reference we have at the time.

@tmeasday tmeasday added the feature New addition or enhancement to existing solutions label Mar 8, 2017
@stale stale bot added the wontfix label Jul 5, 2017
@settings settings bot removed the wontfix label Jul 8, 2017
@rcoedo
Copy link
Contributor

rcoedo commented Jul 13, 2017

I stumbled upon this problem yesterday and I was really confused. In my case, I got problems using react-apollo with storybook. I made a small playground that shows the problem here.

@stale
Copy link

stale bot commented Aug 3, 2017

This issue has been automatically labled because it has not had recent activity. If you have not received a response from anyone, please mention the repository maintainer (most likely @jbaxleyiii). It will be closed if no further activity occurs. Thank you for your contributions to React Apollo!

@jbaxleyiii
Copy link
Contributor

There is a PR in progress on this! Thanks @probot-stale[bot]

@stale stale bot removed the no-recent-activity label Aug 3, 2017
rcoedo pushed a commit to rcoedo/react-apollo that referenced this issue Aug 8, 2017
rcoedo pushed a commit to rcoedo/react-apollo that referenced this issue Aug 8, 2017
rcoedo pushed a commit to rcoedo/react-apollo that referenced this issue Aug 8, 2017
rcoedo pushed a commit to rcoedo/react-apollo that referenced this issue Aug 8, 2017
@stale
Copy link

stale bot commented Aug 24, 2017

This issue has been automatically labled because it has not had recent activity. If you have not received a response from anyone, please mention the repository maintainer (most likely @jbaxleyiii). It will be closed if no further activity occurs. Thank you for your contributions to React Apollo!

@stale stale bot closed this as completed Sep 7, 2017
@stale
Copy link

stale bot commented Sep 7, 2017

This issue has been automatically closed because it has not had recent activity after being marked as no recent activyt. If you belive this issue is still a problem or should be reopened, please reopen it! Thank you for your contributions to React Apollo!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New addition or enhancement to existing solutions
Projects
None yet
Development

No branches or pull requests

3 participants