Add a(n optional) generic type map to PubSub.

[k-tten]

The class PubSub now has a generic type parameter so its methods publish and subscribe can be optionally type-checked by TypeScript.

• has-reproduction
• feature
• blocking
• good first review

/label typedefs

I was using apollo-server-express but the class PubSub did not have any compile time validation by TypeScript. So I extended the class and added a generic. I thought I would contribute to the project back since it will be useful to others.

New usage:

import { PubSub } from "apollo-server-express";

const pubsub = new PubSub<{
    EVENT_ONE: { data: number; };
    EVENT_TWO: { data: string; };
}>();

pubsub.publish("EVENT_ONE", { data: 42 });
pubsub.publish("EVENTONE", { data: 42 }); // ! ERROR
pubsub.publish("EVENT_ONE", { data: "42" }); // ! ERROR
pubsub.publish("EVENT_TWO", { data: "hello" });

pubsub.subscribe("EVENT_ONE", () => {});
pubsub.subscribe("EVENTONE", () => {}); // ! ERROR
pubsub.subscribe("EVENT_TWO", () => {});

const oldPubSub = new PubSub(); // => Still completely fine and should act as if the optional generic was never added.

[cursedstuff]

Looks good! Updating the examples on the README.md would be good as well.

[k-tten]

Yep! I updated the README as well to feature this if it ever gets merged.

[k-tten]

Related: #223

[n1ru4l]

@glasser This is something that should be added to the v3.0 release: https://github.com/apollographql/graphql-subscriptions/milestone/1

This has been out here for a while: https://github.com/contra/typed-graphql-subscriptions

[hwillson]

Thanks for this @cursorsdottsx!