Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Fix side tabs resize #19

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

spencersteers
Copy link

@spencersteers spencersteers commented Aug 24, 2019

Fixes apollographql/apollo-server#2529.

Changes proposed in this pull request:

  • Bind missing action changeWidthDocs so that the tabs can resize

@abernix

Side not I also noticed an issue that occurs when:

  • Resize small enough to close
  • Keep holding mouse down and resize open
  • Tab reopens with blank window

This is also occurring in prisma. Should I try to take care of this as well or want to just get this fix in?

resize-while-holding-mouse-down-bug

@apollo-cla
Copy link

@spencersteers: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@spencersteers
Copy link
Author

Found an easy fix for whats mentioned above by calling return onMouseUp(); after the resize closes the panel. Let me know if you think it is worth adding it in - don't want to scope creep :)

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's punt the other fixes to another PR, mainly so that we have separate published versions which fix different problems in case someone runs into concerns with one fix or the other. 😄

@abernix abernix merged commit 0bfb101 into apollographql:apollo Aug 28, 2019
abernix added a commit that referenced this pull request Aug 28, 2019
abernix added a commit to apollographql/apollo-server that referenced this pull request Aug 28, 2019
Via an upstream PR provided by @spencersteers, this fixes a regression in
GraphQL Playground which prevented the resizing of the schema panel.  This
regression seems to have been introduced by
graphql/graphql-playground#1001, which removed the
relevant binding.

See referenced issues for additional details into the change.

Ref: apollographql/graphql-playground#19
Fixes: #2529
abernix added a commit to apollographql/apollo-server that referenced this pull request Aug 28, 2019
Via an upstream PR provided by @spencersteers, this fixes a regression in
GraphQL Playground which prevented the resizing of the schema panel.  This
regression seems to have been introduced by
graphql/graphql-playground#1001, which removed the
relevant binding.

See referenced issues for additional details into the change.

Ref: apollographql/graphql-playground#19
Fixes: #2529
abernix added a commit to apollographql/apollo-server that referenced this pull request Aug 28, 2019
Via an upstream PR provided by @spencersteers, this fixes a regression in
GraphQL Playground which prevented the resizing of the schema panel.  This
regression seems to have been introduced by
graphql/graphql-playground#1001, which removed the
relevant binding.

See referenced issues for additional details into the change.

Ref: apollographql/graphql-playground#19
Fixes: #2529
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playground: Resize schema panel
3 participants