-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use required version of federation coreSpec rather than latest #2528
Conversation
Important points - We get the the version of any core feature implied by that version of federation, unless there has been a major version bump - If there has been a major version bump of the core spec, we get the minimum required version that matches the major version of latest
🦋 Changeset detectedLatest commit: cfdd354 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for apollo-federation-docs canceled.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Note to reviewers: I'm slightly unsure on two points.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor suggestions.
Can we add some integration-ish tests for the composeServices
fn which show various versions being used and the resulting supergraph?
Needs a changeset as well.
Co-authored-by: Trevor Scheer <[email protected]>
So the reason I didn't put any tests into composeServices is that there isn't really anything to test just yet. Since we are saying that this isn't relevant for older versions, We'll always get the latest versions of joinSpec, etc. for now, and it won't become relevant until there is a new version of one of them. |
Important points