Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert removal of url import #2451

Merged
merged 1 commit into from
Mar 10, 2023
Merged

revert removal of url import #2451

merged 1 commit into from
Mar 10, 2023

Conversation

clenfest
Copy link
Contributor

Revert change made in #2293, the router uses deno for the router-bridge, and url is not built in

@clenfest clenfest requested a review from StephenBarlow as a code owner March 10, 2023 21:00
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

🦋 Changeset detected

Latest commit: ad764ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@apollo/federation-internals Patch
@apollo/gateway Patch
@apollo/composition Patch
@apollo/query-planner Patch
@apollo/query-graphs Patch
@apollo/subgraph Patch
apollo-federation-integration-testsuite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Mar 10, 2023

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit ad764ee
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/640b9a6372dfc30008cd744e

@clenfest clenfest changed the base branch from main to next March 10, 2023 21:00
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn. Probably something we can polyfill with rollup but also probably not worth the trouble right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants