Fix issue when type is only reachable through a @provides #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
clenfest
approved these changes
Aug 22, 2022
added 2 commits
August 23, 2022 11:11
It's possible for a type within a subgraph to be only "reachable" through
a provides. Consider:
```graphql
type Query {
t: T @provides(fields: "a { ... on A { x }}")
}
type T @key(fields: "id") {
id: ID!
a: A @external
}
type A {
x: Int
}
```
In that case, type `A` is only mentioned by external field `T.a`, and
as he code was completely ignoring external fields, that type `A` was
not added to the underlying "query graph". But that type _is_ reachable
through the `@provides` on `Query.t`, and as we were trying to handle
that `@provides`, we were running into an assertion error due to `A`
not existing in the "query graph".
This patch ensures that when we have an external field, even if we don't
add any edges, we at least add the target type to the "query graph",
ensuring it exists later as we handle `@provides`.
Fixes apollographql#1935
pcmanus
force-pushed
the
f1935-fragment-in-provides
branch
from
0134ec6 to
78472c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for a type within a subgraph to be only "reachable" through
a provides. Consider:
In that case, type
Ais only mentioned by external fieldT.a, andas he code was completely ignoring external fields, that type
Awasnot added to the underlying "query graph". But that type is reachable
through the
@providesonQuery.t, and as we were trying to handlethat
@provides, we were running into an assertion error due toAnot existing in the "query graph".
This patch ensures that when we have an external field, even if we don't
add any edges, we at least add the target type to the "query graph",
ensuring it exists later as we handle
@provides.Fixes #1935