Code

Add support for inaccessible v0.2#1678

Code

Merged

sachindshinde merged 19 commits intoapollographql:mainapollographql/federation:mainfrom sachindshinde:fed2/inaccessible-v0.2-updatessachindshinde/federation:fed2/inaccessible-v0.2-updatesCopy head branch name to clipboardApr 8, 2022

+3,700-351

Commits

Commits on Apr 7, 2022

• Remove ability to call applyDirective() with Directive, as the codepath is unused and has bugs.

  sachindshinde

  committed
  b17ab7f

  Copy full SHA for b17ab7f

• Fix various bugs in remove() implementations for schema elements, reorder some calls to align on structure, add comments, and fixup their docstrings.

  sachindshinde

  committed
  53027c0

  Copy full SHA for 53027c0

• Fix bug in removeFeatureElements() regarding reference checking.

  sachindshinde

  committed
  a010354

  Copy full SHA for a010354

• Update InaccessibleSpecDefinition, along with subgraph directive definitions and supergraph feature support list

  sachindshinde

  committed
  1b0f820

  Copy full SHA for 1b0f820

• Update removeInaccessibleElements() for inaccessible v0.2 behavior

  sachindshinde

  committed
  a8cdd25

  Copy full SHA for a8cdd25

• Update updateInaccessibleErrorsWithLinkToSubgraphs() for new error codes

  sachindshinde

  committed
  cce7bc9

  Copy full SHA for cce7bc9

• Update existing tests around @inaccessible (mainly this was resolving test case invalidities that are now caught, and switching to double-quote instead of single-quote due to the jest snapshot writ…

  Show description for ac29717
  sachindshinde

  committed
  ac29717

  Copy full SHA for ac29717

• Ensure any given @inaccessible directive is compatible with the stated spec

  sachindshinde

  committed
  604684a

  Copy full SHA for 604684a

• Update tests to check for inaccessible spec issues, forbidden @inaccessible usages, and @inaccessible usages on types

  sachindshinde

  committed
  9cbe0d8

  Copy full SHA for 9cbe0d8

• Update tests for @inaccessible usages on object/interface fields, object/interface arguments, input object fields, enum values, and directive arguments

  sachindshinde

  committed
  1c88ad7

  Copy full SHA for 1c88ad7

• Add test for complex default values and string enum values

  sachindshinde

  committed
  a7f9aa1

  Copy full SHA for a7f9aa1

• Change addValueReferences() to silently ignore errors instead of throwing

  sachindshinde

  committed
  03eeb98

  Copy full SHA for 03eeb98

• Use the same extension property names among errors thrown by removeInaccessibleElements(), and consolidate logic in updateInaccessibleErrorsWithLinkToSubgraphs() more

  sachindshinde

  committed
  56160cd

  Copy full SHA for 56160cd

• Rename removeFeatureElements() to removeAllCoreFeatures()

  sachindshinde

  committed
  c8d8eda

  Copy full SHA for c8d8eda

• Run "npm run error-code-doc"

  sachindshinde

  committed
  8669dc3

  Copy full SHA for 8669dc3

• Move ErrGraphQLAPISchemaValidationFailed() and its code to definitions.ts

  sachindshinde

  committed
  6d30eb6

  Copy full SHA for 6d30eb6

• Fix copy/paste error with printedTagDefinition

  sachindshinde

  committed
  bd179d5

  Copy full SHA for bd179d5

Commits on Apr 8, 2022

• Write test for removeAllCoreFeatures(), and fix bug in CoreFeature.isFeatureDefinition() that the test caught

  sachindshinde

  committed
  cc5181e

  Copy full SHA for cc5181e

• Rename fetchInaccessibleElementsInDescendants() to fetchInaccessibleElementsDeep()

  sachindshinde

  committed
  1035186

  Copy full SHA for 1035186