Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching target for macos CI build is flaky; Unknown Cargo issue. #123

Closed
Enrico2 opened this issue Aug 27, 2020 · 1 comment · Fixed by #128
Closed

Caching target for macos CI build is flaky; Unknown Cargo issue. #123

Enrico2 opened this issue Aug 27, 2020 · 1 comment · Fixed by #128

Comments

@Enrico2
Copy link
Contributor

Enrico2 commented Aug 27, 2020

https://github.com/apollographql/rust/runs/1038067162?check_suite_focus=true

If we disable caching, everything works.
The action is defined as [on cache miss: compile everything and cache] + [load from cache and test]

The reason for this separation is that we could cache compilation if tests fail so that subsequent runs are fast.

When loading target from cache, compilation fails with this error:

   Compiling graphql-parser v0.3.0 (/Users/runner/work/rust/rust/graphql-parser)
error[E0463]: can't find crate for `thiserror_impl` which `thiserror` depends on
 --> graphql-parser/src/error.rs:2:5
  |
2 | use thiserror::Error;
  |     ^^^^^^^^^ can't find crate

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.

We currently do not know why this is happening.
I had suspected some kind of corruption, but Cargo is supposed to be resilient to that. I don't know what conditions would cause Cargo to see this error.

In the interim, the CI actions will be separated to [linux only] and [all] so that we could get quick and reliable feedback from the linux only action. We disabled caching on macos for the slow action.

Enrico2 pushed a commit that referenced this issue Aug 27, 2020
see https://github.com/apollographql/rust/runs/1038067162?check_suite_focus=true
If we disable caching, everything works.
I opened #123 for this problem. In the interim, the CI actions will be separated to [linux only] and [all] so that we could get quick and reliable feedback on PRs from the linux only action. We disabled caching on macos for the slow action.
Enrico2 pushed a commit that referenced this issue Aug 27, 2020
see https://github.com/apollographql/rust/runs/1038067162?check_suite_focus=true
If we disable caching, everything works.
I opened #123 for this problem. In the interim, the CI actions will be separated to [linux only] and [all] so that we could get quick and reliable feedback on PRs from the linux only action. We disabled caching on `macos` for the slow action.
@Enrico2
Copy link
Contributor Author

Enrico2 commented Aug 31, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant