Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

fix: ability to configure interface entities #7

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: ability to configure interface entities #7

merged 1 commit into from
Oct 12, 2023

Conversation

dariuszkuc
Copy link
Member

Adds new KeyInterfaceAttribute that allows specifying @key directive on GraphQL interfaces.

Resolves: #5

Adds new `KeyInterfaceAttribute` that allows specifying `@key` directive on GraphQL interfaces.
@dariuszkuc
Copy link
Member Author

Unsure why but it didn't work when I tried to update KeyAttribute to a generic Attribute and manually applying the directives in the type interceptor. Instead of spending too much time digging into this, this seemed like a simpler fix to unblock the feature.

@github-actions
Copy link

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🔲
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@dariuszkuc dariuszkuc merged commit 7b30f95 into main Oct 12, 2023
2 checks passed
@dariuszkuc dariuszkuc deleted the fed2 branch October 12, 2023 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support @key on interfaces
1 participant