This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
fix: handle non-null in arg parser #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Federated `ArgumentParser` is used to map entity representation to method arguments. When unwrapping nested fields, current logic was not accounting to nullability of the underlying field. If the underlying field returned non-null object, parser would fail trying to find the target property on `NonNull` GraphQL wrapper (which obviously doesn't exist). Updated argument parser object handling logic to unwrap non-null types. Note: this PR only addresses the issue with non-null types. Similar bug is present when handling keys with list representations. Resolves: #6
Apollo Federation Subgraph Compatibility Results
Learn more: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Federated
ArgumentParseris used to map entity representation to method arguments. When unwrapping nested fields, current logic was not accounting to nullability of the underlying field. If the underlying field returned non-null object, parser would fail trying to find the target property onNonNullGraphQL wrapper (which obviously doesn't exist).Updated argument parser object handling logic to unwrap non-null types.
Note: this PR only addresses the issue with non-null types. Similar bug is present when handling keys with list representations.
Resolves: #6