Moved @types definitions to dev dependencies #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danilobuerger we've setup this repo to be run with typescript project references so can you update this PR to move those dev deps to the root package.json? Thanks so much! |
|
@jbaxleyiii those deps are already in the dev dependencies of the root package.json |
|
@danilobuerger could you rebase this on master? |
|
@jbaxleyiii rebased. |
trevor-scheer
added a commit
that referenced
this pull request
Nov 15, 2018
This reverts commit 8169dc1. Reason: @oclif/dev-cli depends on a devDependencies object to exist during publish. It also looks specifically for a typescript field to make decisions. See: https://github.com/oclif/dev-cli/blob/master/src/commands/readme.ts#L199 Currently our publish depends on this behavior, so going to restore it for now.
|
For posterity, this is reverted here: 3663143 Reason for revert is described in the revert commit. Any issues, let me know @danilobuerger. |
|
@trevor-scheer Thats fine with me, I just wanted the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Hopefully) fixes #574