Add @types/node-fetch to apollo-env deps since they are exported #1749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to apollographql/apollo-server#3580. Currently, dependents of
apollo-env
can expect TS build errors if@types/node-fetch
isn't included transitively. This affects the entireapollo-server-*
family viaapollo-server-core
, as seen in this dependency tree:The build error when trying to install
apollo-server-express
in a typescript project:Exporting these^ from the root of
apollo-env
like this requires thatapollo-env
should list the@types/node-fetch
as a project dependency.TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.