Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apollo-server-core runQuery breaks async_hook tracking #733

Merged
merged 1 commit into from
Dec 22, 2017

Conversation

domarmstrong
Copy link
Contributor

@domarmstrong domarmstrong commented Dec 21, 2017

By creating a promise out of the execution flow the ability to trace the
async call stack is lost.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@domarmstrong: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

By creating a promise out of the execution flow the ability to trace the
async call stack is lost.
@martijnwalraven martijnwalraven merged commit a8ae904 into apollographql:master Dec 22, 2017
@martijnwalraven
Copy link
Contributor

Thanks!

abernix added a commit to dandean/apollo-server that referenced this pull request Mar 26, 2018
abernix added a commit that referenced this pull request Mar 26, 2018
CaptainJojo pushed a commit to CaptainJojo/apollo-server that referenced this pull request Apr 5, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants