Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support older input formats for building a schema #3188

Merged
merged 5 commits into from
Aug 23, 2019

Conversation

jbaxleyiii
Copy link
Contributor

Support older input formats for building a schema from typeDefs where typeDefs could be either an array of DocumentNodes or a single DocumenNode attached to an object with a possible resolver map. This shouldn't be supported in the next major version of ApolloServer when we have a more structured approach to modules, but for now this makes migration to federated services much easier for teams that have an existing set of typeDefs generated from their project (often in .graphql files).

@jbaxleyiii jbaxleyiii requested a review from abernix August 23, 2019 01:22
typeDefs could be either an array of DocumentNodes or a single DocumenNode attached to an object with a possible resovler map. This shouldn't be supported in the next major version of ApolloServer when we have a more structured approach to modules, but for now this makes migration to federated services much easier for teams that have an existing set of typeDefs generated from their project (often in .graphql files).
@jbaxleyiii jbaxleyiii force-pushed the jbaxleyiii/buildFederateSchema-API branch from 8d9548e to fa2aa6c Compare August 23, 2019 01:24
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed two commits directly to this PR which I'm certain you won't find offensive, but I've left one remaining comment regarding the claim of this PR itself.

Otherwise, this looks great!

CHANGELOG.md Outdated Show resolved Hide resolved
James Baxley and others added 2 commits August 23, 2019 06:39
Co-Authored-By: Jesse Rosenberger <[email protected]>
Removing the extra letter from this variable necessitates changing all the
things, apparently.
@abernix abernix merged commit 8557e85 into master Aug 23, 2019
@abernix abernix deleted the jbaxleyiii/buildFederateSchema-API branch August 23, 2019 11:04
@abernix
Copy link
Member

abernix commented Aug 23, 2019

Released in @apollo/[email protected].

abernix pushed a commit to apollographql/federation that referenced this pull request Sep 4, 2020
…de[]`s only). (apollographql/apollo-server#3188)

* Support older input formats for building a schema from typeDefs where
typeDefs could be either an array of DocumentNodes or a single DocumenNode attached to an object with a possible resovler map. This shouldn't be supported in the next major version of ApolloServer when we have a more structured approach to modules, but for now this makes migration to federated services much easier for teams that have an existing set of typeDefs generated from their project (often in .graphql files).

* Adjust spelling of variable.

* Add period on end of sentence in CHANGELOG.md.

* Update CHANGELOG.md

Co-Authored-By: Jesse Rosenberger <[email protected]>

* Oh Prettier, I'm coming for you.

Removing the extra letter from this variable necessitates changing all the
things, apparently.

Apollo-Orig-Commit-AS: apollographql/apollo-server@8557e85
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants