apollo-engine-reporting: don't fail if errors have non-array 'path' #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, we found that some network errors talking to federated backends could have a string path.
glasser
force-pushed
the
glasser/aer-path-array
branch
from
1372a97 to
5b8565a
Compare
|
Feel free to merge and release. |
abernix
approved these changes
Jul 31, 2019
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…pollographql/apollo-server#3112) * apollo-engine-reporting: don't fail if errors have non-array 'path' Specifically, we found that some network errors talking to federated backends could have a string path. * Just use `Array.isArray`, which returns `false` when passed `undefined`. Nit, of course. Apollo-Orig-Commit-AS: apollographql/apollo-server@1acf62d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, we found that some network errors talking to federated backends
could have a string path.