Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reporting: fix forbidden/unregistered op reporting #2828

Merged
merged 2 commits into from
Jun 11, 2019

Conversation

evans
Copy link
Contributor

@evans evans commented Jun 11, 2019

Marking of operations as registered and forbidden in traces happens too early in the request pipeline, so this PR places the condition check at the end of the request

@evans evans requested a review from cheapsteak June 11, 2019 20:29
Copy link
Member

@cheapsteak cheapsteak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@evans evans merged commit aefe8ea into master Jun 11, 2019
@evans evans deleted the evans/fix-registration-reporting branch June 11, 2019 23:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants