Fix Typescript import error: TS1192 module has no default export

[Arthie]

I get the following error when using the apollo-server-core with typescript (3.2.4) :

node_modules/apollo-server-core/dist/types.d.ts:4:8 - error TS1192: Module '"/node_modules/@types/ws/index"' has no default export.
import WebSocket from 'ws';

The change fixes this error!

TODO:

• Update CHANGELOG.md with your change (include reference to issue & this PR)
• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass

[apollo-cla]

@Arthie: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[abernix]

@Arthie I do believe we need to provide a fix here, but can you provide a use-case/code-snippet showing exactly how you're encountering this type error, in usage of apollo-server-*, for posterity's sake? Are you using something from apollo-server-core?

[Arthie]

@abernix

Just importing ApolloServer from apollo-server-lambda in a file is enough to trigger the error:
import { ApolloServer } from "apollo-server-lambda";

Here is my typescript config:

{
  "compilerOptions": {
    "lib": ["es2017", "esnext.asynciterable"],
    "moduleResolution": "node",
    "noEmit": true,
    "noUnusedLocals": false,
    "noUnusedParameters": false,
    "allowUnreachableCode": false,
    "strict": true,
    "sourceMap": true,
    "target": "es2017",
    "outDir": "dist",
    "baseUrl": "src",
  },
  "include": ["src/**/*"],
  "exclude": ["node_modules", "**/*.graphql"]
}

I also get a secondary error similar to the first one but in apollo-server-lambda:

node_modules/apollo-server-lambda/dist/ApolloServer.d.ts:1:8 - error TS1192: Module '".../node_modules/@types/aws-lambda/index"' has no default export.

1 import lambda from 'aws-lambda';

[Arthie]

@abernix Added a new commit to fix the secondary import error. The aws-lamda types package also has no default export.

Summery of this tiny patch:
Fixes 2 import errors: error TS1192: module ... has no default export
import from package ws in apollo-server-core and aws-lambda in apollo-server-lambda

[abernix]

I made a couple follow-up commits to avoid using star-imports, since we've generally moved toward esModuleInterop patterns (which is the default with new tsc --init projects), but this looks great. Thanks for opening this. Hopefully we can get a release cut soon to validate the success.

[abernix]

This has been included in 2.4.3. I plan on promoting it to the latest tag tomorrow, but you can try this right now using the next tag or by directly installing 2.4.3. e.g.:

npm install [email protected]

[Arthie]

Tested version [email protected] and got no errors! Thank you 👍

[abernix]

Thank you for this first contribution!