Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose express from ApolloServer #2124

Closed
wants to merge 7 commits into from
Closed

feat: expose express from ApolloServer #2124

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
99f7896
chore: expose express from ApolloServer
playerx Dec 21, 2018
f1c28d9
fix: linter issue
playerx Dec 21, 2018
6abb1ac
Merge branch 'master' into patch-1
playerx Dec 22, 2018
a6e13d6
Merge branch 'master' into patch-1
playerx Dec 28, 2018
e4d1b1e
Merge branch 'master' into patch-1
playerx Jan 4, 2019
d741dd4
Merge branch 'master' into patch-1
playerx Jan 8, 2019
a3eee5e
Merge branch 'master' into patch-1
playerx Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/apollo-server/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,19 @@ export interface ServerInfo {
}

export class ApolloServer extends ApolloServerBase {
public express: express.Express;
private httpServer?: http.Server;
private cors?: CorsOptions | boolean;

constructor(config: Config & { cors?: CorsOptions | boolean }) {
constructor(
config: Config & {
cors?: CorsOptions | boolean;
express?: express.Express;
},
) {
super(config);
this.cors = config && config.cors;
this.express = (config && config.express) || (express && express());
}

private createServerInfo(
Expand Down Expand Up @@ -82,7 +89,7 @@ export class ApolloServer extends ApolloServerBase {

// This class is the easy mode for people who don't create their own express
// object, so we have to create it.
const app = express();
const app = this.express;

// provide generous values for the getting started experience
super.applyMiddleware({
Expand Down