chores: Request pipeline readability/DRYing. #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is so large this was just low-hanging fruit along a path of potential opportunities.
…idEnd`. Rather than crutching on the `return`, this logic reads more concisely with a full `if` / `else` pattern. I say this because two people looked at it and weren't immediately aware, which really shouldn't be the case from such a brief piece of code.
…per. Introduces a helper function to DRY-up the increasingly-repeated pattern of sending an error response in the event of request errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few low-hanging fruit commits in a never-ending pursuit to streamline the request pipeline.
These should be effective no-ops, but are more relevant given another PR which I'm in the process of staging. Whether or not that PR lands, I think these should still be drops in the improvements bucket. 🥝📈