Make mocking configuration less confusing.

[deftomat]

We had a few WTF? situations 😉 with the following Apollo server config:

const config = {
  typeDefs,
  resolvers,
  mocks: false,
  mockEntireSchema: false,
}

Everyone in our team assumed that you can disable the mocks by setting the mocks property to false.
However, according to:

apollo-server/packages/apollo-server-core/src/ApolloServer.ts

Line 257 in a12673a

if (mocks || typeof mockEntireSchema !== 'undefined') {

The mocks will be enabled when you provide mocksEntireSchema together with mocks. It doesn't matter if mocks is true or false or an object.

I'm not sure if this is an intended behaviour but I can definitely say that it is really confusing.
Can we update it to disable mocks when mocks property is false?

(Feel free to close this PR if the current behaviour is an intended behaviour)

[apollo-cla]

@deftomat: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[JakeDawkins]

Hey @deftomat Thanks for looking into this! I've been meaning to look at it. Question: wouldn't this end up doing the same thing?

Suggested change

	if (mocks || (typeof mockEntireSchema !== 'undefined' && mocks !== false)) {
	if (mocks) {

[JakeDawkins]

To my understanding, this is the current intended behavior:

mocks: false

• no matter what, no mocks get added

mocks: true

• by default, mocks all resolvers
• mockEntireSchema: false to overwrite this

[deftomat]

Well, in my code, you can enable mocks by setting mockEntireSchema without bothering about mocks property.
By looking at the next lines, you can see that it is an intended behaviour to be able to enable mocks just by using mockEntireSchema.

[JakeDawkins]

Yep! That makes more sense actually 👌 Thanks for clarifying @deftomat

[JakeDawkins]

@deftomat Can you add this line to CHANGELOG.md for me? FYI, you may need to pull first also, since I updated the branch

- Fix mocks configuration to allow disabling of mocks by using `mocks: false`, even if `mockEntireSchema` is `true` [PR #1835](https://github.com/apollographql/apollo-server/pull/1835)

[deftomat]

@JakeDawkins done!

[JakeDawkins]

Thanks for the help @deftomat!