-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest-datasource): support redis cluster and sentinel #1770
feat(rest-datasource): support redis cluster and sentinel #1770
Conversation
@eberhara: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
1db59d9
to
c8b4a2d
Compare
198ee4a
to
8241c81
Compare
Codecov Report
@@ Coverage Diff @@
## master #1770 +/- ##
===========================================
- Coverage 89.67% 74.72% -14.95%
===========================================
Files 5 32 +27
Lines 184 1203 +1019
Branches 38 291 +253
===========================================
+ Hits 165 899 +734
- Misses 18 294 +276
- Partials 1 10 +9
Continue to review full report at Codecov.
|
1dc5c14
to
e00b347
Compare
aec04cf
to
318c871
Compare
Just rebased the branch again so someone can review it. ✅ |
@shinyaohira wondering if you got any chance to review this PR? |
packages/apollo-server-cache-redis-cluster/src/RedisClusterCache.ts
Outdated
Show resolved
Hide resolved
packages/apollo-server-cache-redis-cluster/src/RedisClusterCache.ts
Outdated
Show resolved
Hide resolved
packages/apollo-server-cache-redis-cluster/src/RedisClusterCache.ts
Outdated
Show resolved
Hide resolved
packages/apollo-server-cache-redis-cluster/src/RedisClusterCache.ts
Outdated
Show resolved
Hide resolved
@eberhara @veeramarni I've commented about some minor issues, documentation and typings. I think the code itself is ok 👍 |
Would love to see some attention to this PR. It seems simple and well done by @eberhara. Since redis is so often used with clustering and sentinel, this would be a huge win for Apollo Server caching IMO. On whether it should replace the existing module, I'm not sure. Since they have different features, I'd lean towards adding a new module, as @eberhara has suggested. |
@eberhara Would you consider creating a separate package for this? Or would you mind if someone else did? |
hey @ulrikstrid . I actually believe a separate package is a more elegant solution. However I don't feel I'll have time next week to doing so. Are you planning create the separate package? |
I vendored your code for now but can create a repo and publish to npm as it seems you're okay with it |
@ulrikstrid could you please do it ? this pr seems to be a deadend, we'd really like to be able to use redis sentinel. |
@benoitemile I'm working on it right now, Will report back here when it's done. |
Just checking if anyone has created a package for it? Either way please let us know. |
I've created this repo https://github.com/XenitAB/apollo-server-cache-redisio but have not had time to finish everything yet |
We're doing a major version bump here, so I'm going to take the opportunity to "drop" Node.js 6 support. Granted, this `engines` field is only a suggestion that is loosely enforced by some tools (and not obeyed by Node.js or npm), it's the spirit of the thought that counts, I think? :)
@abernix does this merge mean that it's going to be moved into master? |
Sorry for the long delay here. I've merged in Since this is a breaking change (I think?), if someone can make sure that there's some brief/necessary/clear instructions added to the Thanks! |
hey @abernix ! Just added the instructions to the Changelog! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for working on this, and apologies for how long it took to land. The plan is to publish this as an alpha from the release-2.6.0
branch pretty soon (and I've updated the target branch for this PR to release-2.6.0
accordingly).
These are great news @abernix ! |
…e 2.6.0. For sanity purposes. Ref: #1770
I've published Thanks again for working on this! |
@eberhara @shinyaohira I understand this is an old PR ofc, but just out of curiosity, what exactly does DataLoader solves here? Thank you |
@kbariotis it combines multiple |
This PR adds a new package called
apollo-server-cache-redis-cluster
that supports Redis Cluster and Sentinels on data sources caching.Fixes #1750 and fixes #1725.
TODO: