feat(uploads): replace apollo-upload-server v5 with graphql-upload v8

[lgaticaq]

Fix #1703 and #1509
Migrate @apollographql/apollo-upload-server to graphql-upload

TODO:

• Update CHANGELOG.md with your change (include reference to issue & this PR)
• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass

[apollo-cla]

@lgaticaq: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[codecov-io]

Codecov Report

Merging #1764 into master will decrease coverage by 3.98%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1764      +/-   ##
==========================================
- Coverage    77.8%   73.82%   -3.99%     
==========================================
  Files          30       29       -1     
  Lines        1149     1150       +1     
  Branches      268      288      +20     
==========================================
- Hits          894      849      -45     
- Misses        245      291      +46     
  Partials       10       10

Impacted Files	Coverage Δ
packages/apollo-server-koa/src/ApolloServer.ts	90.76% <100%> (ø)	⬆️
packages/apollo-server-micro/src/ApolloServer.ts	100% <100%> (ø)	⬆️
packages/apollo-server-hapi/src/ApolloServer.ts	95.74% <100%> (ø)	⬆️
packages/apollo-server-express/src/ApolloServer.ts	90% <100%> (ø)	⬆️
packages/apollo-server-core/src/runHttpQuery.ts	30.2% <0%> (-17.03%)	⬇️
packages/apollo-server/src/index.ts	96.77% <0%> (-0.11%)	⬇️
...ackages/apollo-server-express/src/expressApollo.ts	86.36% <0%> (ø)	⬆️
packages/apollo-server-core/src/graphqlOptions.ts	75% <0%> (ø)	⬆️
packages/apollo-datasource-rest/src/HTTPCache.ts	97.87% <0%> (ø)	⬆️
...ackages/apollo-server-core/src/utils/dispatcher.ts
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94fc935...6ea127a. Read the comment docs.

[lgaticaq]

Close this PR because make changes in https://github.com/apollographql/apollo-upload-server/pull/3

[edevil]

Since this fixes security problems I’m very much in favor.

[jaydenseric]

Keep in mind the engines.node field of relevant packages will need to be updated, as graphql-upload upped support to Node.js v8.5+; see jaydenseric/graphql-upload#109.

[jaydenseric]

CI will need to be reconfigured to not test on Node.js v6: https://github.com/apollographql/apollo-server/blob/master/.circleci/config.yml#L106

[juona]

Is there any plan to resolve this?

[edevil]

I was under the impression this would be included in 2.2.0. Is there anything that I can do to help move this along? @abernix @martijnwalraven @lgaticaq

[martijnwalraven]

@edevil We can't include this in 2.2 because it's a breaking change to drop Node 6 support.

[edevil]

@martijnwalraven Oh, I see. :( So I guess this is not something for the near future, right?

[abernix]

Superseded by #2054. Thank you very much for taking the time to work on this!

I'd really appreciate if you could try the alpha release I published off that PR — [email protected] — and detail any problems (or successes!) you encounter with the upgrade.

Ref: #2054 (comment)

[abernix]

The alpha releases didn't identify any problems so I've graduated this to the official apollo-server-*@2.3.0 releases.