Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ApolloServerBase.schema from private access to protected access. #1610

Merged
merged 4 commits into from
Sep 5, 2018
Merged

Switch ApolloServerBase.schema from private access to protected access. #1610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3524744
Update ApolloServer.ts
vincenzo Sep 4, 2018
b254bc7
Update CHANGELOG.md
vincenzo Sep 4, 2018
2d4fbed
Fix linting issue
vincenzo Sep 4, 2018
368accc
Merge branch 'master' into master
martijnwalraven Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ All of the packages in the `apollo-server` repo are released with the same versi
- Update `graphql-playground-html` to 1.7.4 [#1586](https://github.com/apollographql/apollo-server/pull/1586)
- Add support for `graphql-js` v14 by augmenting typeDefs with the `@cacheControl` directive so SDL validation doesn't fail [#1595](https://github.com/apollographql/apollo-server/pull/1595)
- Add `node-fetch` extensions typing to `RequestInit` [#1602](https://github.com/apollographql/apollo-server/pull/1602)
- Switch `ApolloServerBase.schema` from private access to protected access. [#1610](https://github.com/apollographql/apollo-server/pull/1610)
- Add toggle for including error messages in reports [#1615](https://github.com/apollographql/apollo-server/pull/1615)
- Fix `apollo-server-cloud-functions` tests [#1611](https://github.com/apollographql/apollo-server/pull/1611/)

Expand Down
3 changes: 2 additions & 1 deletion packages/apollo-server-core/src/ApolloServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,11 @@ export class ApolloServerBase {
public graphqlPath: string = '/graphql';
public requestOptions: Partial<GraphQLOptions<any>>;

private schema: GraphQLSchema;
private context?: Context | ContextFunction;
private engineReportingAgent?: EngineReportingAgent;
private extensions: Array<() => GraphQLExtension>;

protected schema: GraphQLSchema;
protected subscriptionServerOptions?: SubscriptionServerOptions;
protected uploadsConfig?: FileUploadOptions;

Expand Down