Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-fetch extensions typing #1602

Merged

Conversation

shinyaohira
Copy link
Contributor

  • follow
  • timeout
  • compress
  • size
  • agent

to RequestInit interface. See node-fetch README.
I think we need these options for production services.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@ghost ghost added the ⛲️ feature New addition or enhancement to existing solutions label Sep 2, 2018
@apollo-cla
Copy link

@shinyaohira: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@shinyaohira shinyaohira force-pushed the node-fetch-extensions branch from e9adc90 to fe95808 Compare September 2, 2018 04:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⛲️ feature New addition or enhancement to existing solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants