Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit any types in apollo-server-cloud-function #1554

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

tgriesser
Copy link
Contributor

I was working on a separate feature and the build was failing locally with several implicit any type warnings from the merge of #1446, so I decided to fix them.

Google cloud functions appears to use express internally, so I used those type definitions to type the req / res params.

I didn't look to see why this would have originally passed CI without any issues.

@evans evans merged commit 99e4357 into apollographql:master Aug 20, 2018
@evans
Copy link
Contributor

evans commented Aug 20, 2018

@tgriesser Thanks a lot!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants