Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Improvements and esModuleInterop fix #1210

Merged
merged 4 commits into from
Jun 20, 2018
Merged

Conversation

evans
Copy link
Contributor

@evans evans commented Jun 20, 2018

This removes exModuleInterop, which was breaking some builds with TS #1182

Additionally adds in support for strings passed directly to gql and adds the documentation requested by #1194. For example:

const typeDefinitions = readFileSync(join(__dirname, "../../schema.graphql"), "utf8");

export default gql`
  ${typeDefinitions}
`;

//vs 

const typeDefinitions = gql(readFileSync(join(__dirname, "../../schema.graphql"), "utf8"));


// app file
const apolloServer = new ApolloServer({ typeDefs, resolvers });

@evans evans changed the base branch from master to version-2 June 20, 2018 21:53
@evans evans changed the title Server 2.0/typescript Typescript Improvements and esModuleInterop fix Jun 20, 2018
@evans evans merged commit 9af856c into version-2 Jun 20, 2018
@evans evans deleted the server-2.0/typescript branch June 20, 2018 23:21
@evans evans mentioned this pull request Jun 21, 2018
hwillson added a commit that referenced this pull request Sep 20, 2018
`esModuleInterop` was enabled in
e4164c8
to help with importing from packages that use default exports.
Those changes were reverted in
#1210
to work around a few reported issues. Those issues are no longer
relevant, so this commit re-enables `esModuleInterop`, and
updates all default imports to use the more common (standard)
import syntax.
abernix pushed a commit that referenced this pull request Sep 21, 2018
`esModuleInterop` was enabled in
e4164c8
to help with importing from packages that use default exports.
Those changes were reverted in
#1210
to work around a few reported issues. Those issues are no longer
relevant, so this commit re-enables `esModuleInterop`, and
updates all default imports to use the more common (standard)
import syntax.
ShiyamRajan pushed a commit to ShiyamRajan/apollo-server-lambda that referenced this pull request Nov 2, 2018
`esModuleInterop` was enabled in
apollographql/apollo-server@e4164c8
to help with importing from packages that use default exports.
Those changes were reverted in
apollographql/apollo-server#1210
to work around a few reported issues. Those issues are no longer
relevant, so this commit re-enables `esModuleInterop`, and
updates all default imports to use the more common (standard)
import syntax.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant