Add mocking to base server constructor #1006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
evans
changed the title
|
This PR is superseded by #1017 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mocking to the new apollo server by adding a parameter to the constructor. The parameter,
mockallows a user to specify a boolean or an object containing mocks for types/objects. The default is to preserve the resolvers. If a user would like to remove the resolvers, then they must comment out the resolvers passed to the constructor, which I believe to be a better alternative to thepreserveResolversparameter currently found inaddMockFunctionToSchema.The changes apply directly to the Base server implementation, so all variants receive the changes.
Documentation to come in #1007.